[PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection

[Chen-Yu Tsai]

On Mon, Mar 4, 2024 at 4:47 PM Uwe Kleine-König <ukleinek at debian.org> wrote:
>
> While it requires to have the right phy driver loaded (i.e. motorcomm)
> to make the phy asserting the right delays, this is generally the
> preferred way to define the MAC <-> PHY connection.
>
> Signed-off-by: Uwe Kleine-König <ukleinek at debian.org>
> ---
> Hello,
>
> Andrew already pointed out when I posted the patch introducing the gmac0 node
> that rgmii-id would be the preferred way to setup things. Back then this didn't
> happen because this change broke reception of network packets. However this
> only happend because I didn't have the right phy driver loaded.

It could be that the PHY is strapped to not use its internal RX delay.
And the PHY has some weird default TX delay, so having the driver
put some sensible values in is probably better.

ChenYu

> Best regards
> Uwe
>
>  arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> index 6a998166003c..36ad48d46bc1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> @@ -20,15 +20,13 @@ &gmac0 {
>         assigned-clock-rates = <0>, <125000000>;
>         clock_in_out = "output";
>         phy-handle = <&rgmii_phy0>;
> -       phy-mode = "rgmii";
> +       phy-mode = "rgmii-id";
>         pinctrl-names = "default";
>         pinctrl-0 = <&gmac0_miim
>                      &gmac0_tx_bus2
>                      &gmac0_rx_bus2
>                      &gmac0_rgmii_clk
>                      &gmac0_rgmii_bus>;
> -       rx_delay = <0x2f>;
> -       tx_delay = <0x3c>;
>         status = "okay";
>  };
>
>
> base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89
> --
> 2.43.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel