[PATCH v2 4/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description.
Krzysztof Kozlowski
krzk at kernel.org
Mon Jun 24 04:45:34 PDT 2024
On 24/06/2024 10:19, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.
Which devices have this clock? All? You now mention driver, but this is
a binding so please describe hardware.
Subject: drop full stops. In every patch.
>
> Signed-off-by: Jacobe Zang <jacobe.zang at wesion.com>
> ---
> .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index e564f20d8f415..b9e39a62c3b32 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -121,6 +121,15 @@ properties:
> NVRAM. This would normally be filled in by the bootloader from platform
> configuration data.
>
> + clocks:
> + description: phandle to the clock connected on rtc clock line.
Drop redundant parts, like "phandle to the". Just use items with
description instead of above and maxItems.
> + maxItems: 1
> +
> + clock-names:
> + description: Names of the supplied clocks.
Drop description, completely redundant.
> + items:
> + - const: 32k
32k? That's the name of the clock? In the datasheet?
> +
> required:
> - compatible
> - reg
Best regards,
Krzysztof
More information about the Linux-rockchip
mailing list