[PATCH 2/5] arm64: dts: rockchip: Fix regulators, gmac and naming on NanoPi R6C/R6S
Heiko Stübner
heiko at sntech.de
Thu Jun 20 11:39:44 PDT 2024
Am Mittwoch, 12. Juni 2024, 22:48:11 CEST schrieb Sebastian Kropatsch:
> Fix the alphabetical ordering in some nodes and rename some regulators
> and pins to match the schematics [1][2] as well as to adhere to
> preferred naming schemes.
General rule of thumb, when you need an "and" in your subject or a list
like the above - you definitly want to split the change into multiple
commits.
> In addition to that:
> * vcc_3v3_sd_s0: Fix voltage to be 3.3V
> * vcc3v3_pcie:
> - Move to NanoPi R6C, this power switch is not available on R6S
> - Fix vin-supply (is vcc_5v0 per schematics)
> - Add gpios/pincrtl to enable power
this defnitly needs its own patch
> * vcc5v0_usb: Remove this regulator since according to the schematics,
this too
> * vcc5v0_host_20 and vcc5v0_usb_otg0 are directly powered by vcc_5v0
this could be grouped together with the 3.3v change
> * gmac1: Add rx_delay of 0 (no delay since phy-mode = "rgmii-rxid")
with rxid mode, why is the rx_delay needed at all?
Shouldn't this just work without the property?
> * rgmii_phy1: Add phy-supply as seen in schematics
separate patch
> * pcie2*:
> - Add pinctrl reset pins
> - Update vpcie3v3-supply to match the schematics
separate patch
> * sdhci: Add vmmc-supply and vqmmc-supply
separate patch
Heiko
More information about the Linux-rockchip
mailing list