[PATCH 1/3] media: rockchip: Introduce the rkvdec2 driver
Jianfeng Liu
liujianfeng1994 at gmail.com
Tue Jun 18 05:13:29 PDT 2024
Hi Detlev,
On Fri, 14 Jun 2024 21:56:27 -0400, Detlev Casanova wrote:
>+ .frmsize = {
>+ .min_width = 16,
>+ .max_width = 65520,
>+ .step_width = 16,
>+ .min_height = 16,
>+ .max_height = 65520,
>+ .step_height = 16,
>+ },
I think the min/max width/height are incorrect. From rockchip's TRM V1.0
Part1 page 374, supported image size is 64x64 to 65472x65472. And my
chromium can't use rkvdec2 because min width/height are set to 16, which
will cause error at here in rkvdec2_h264_validate_sps:
>+ if (width > ctx->coded_fmt.fmt.pix_mp.width ||
>+ height > ctx->coded_fmt.fmt.pix_mp.height)
>+ return -EINVAL;
width is 16, height is 32 while ctx->coded_fmt.fmt.pix_mp.width and
ctx->coded_fmt.fmt.pix_mp.height are both 16.
After changing them to 64 my chromium can use rkvdec2 to decode h264
videos now.
Anyway many thanks to your amazing work!
Best regards,
Jianfeng
More information about the Linux-rockchip
mailing list