[PATCH] arm64: dts: rockchip: make "poweroff" work on rock-5a

[Dragan Simic]

Hello Fukami,

On 2024-06-11 14:27, FUKAUMI Naoki wrote:
> to make "poweroff" command work, add "system-power-controller;" into
> pmic at 0. without this, "poweroff" works as same as "reboot".
> 
> Fixes: 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a")
> 
> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>

Looking good to me, with a small remark below.

Reviewed-by: Dragan Simic <dsimic at manjaro.org>

> ---
>  arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> index b070955627be..cf7b878a3eb2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> @@ -395,6 +395,8 @@ pmic at 0 {
>  			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
>  		spi-max-frequency = <1000000>;
> 

I don't think there's need for the empty line right above, i.e.
between the "spi-max-frequency" and "system-power-controller" lines.

> +		system-power-controller;
> +
>  		vcc1-supply = <&vcc5v0_sys>;
>  		vcc2-supply = <&vcc5v0_sys>;
>  		vcc3-supply = <&vcc5v0_sys>;