[PATCH v2 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5 GenBook
Krzysztof Kozlowski
krzk at kernel.org
Sun Jul 28 02:15:14 PDT 2024
On 28/07/2024 10:20, Andy Yan wrote:
> Add Cool Pi CM5 GenBook, a laptop powered by RK3588.
>
> Cool Pi GenBook works with a carrier board connect
> with CM5.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Andy Yan <andyshrk at 163.com>
>
> ---
>
> Changes in v2:
> - Descripte it as Cool Pi CM5 GenBook
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1ef09fbfdfaf..a9bfb87e69f5 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -96,6 +96,14 @@ properties:
> - const: coolpi,pi-cm5
> - const: rockchip,rk3588
>
> + - description: Cool Pi CM5 GenBook
> + items:
> + - enum:
> + - coolpi,genbook
> + - const: coolpi,pi-cm5
> + - const: rockchip,rk3588
> +
> +
Just one blank line. Please always take a look how the code looks around
and do not implement things entirely different. Like odd blank lines.
Best regards,
Krzysztof
More information about the Linux-rockchip
mailing list