Re: [PATCH 1/4] clk:?==?utf-8?q? rockchip: rst-rk3588: Add BIU reset

Shreeya Patel shreeya.patel at
Fri Feb 16 04:48:10 PST 2024

On Friday, February 16, 2024 15:33 IST, Krzysztof Kozlowski <krzysztof.kozlowski at> wrote:

> On 16/02/2024 10:49, Shreeya Patel wrote:
> > Export hdmirx_biu soft reset id which is required by the hdmirx controller.
> > 
> > Signed-off-by: Shreeya Patel <shreeya.patel at>
> > ---
> >  drivers/clk/rockchip/rst-rk3588.c               | 1 +
> >  include/dt-bindings/reset/rockchip,rk3588-cru.h | 2 ++
> Please run scripts/ and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
> Please do internal review. The internal Collabora review would tell you:
> YOU MUST run checkpatch. Then you see errors, so why do you send patch
> with errors to the mailing list?

I am sorry but what errors are you talking about?
I don't see any errors reported by checkpatch :-

shreeya at shreeya:~/collabora/rd/rockchip/torvalds$ ./scripts/ hdmirx/0001-clk-rockchip-rst-rk3588-Add-BIU-reset.patch
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

total: 0 errors, 1 warnings, 13 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

hdmirx-v1-1602/0001-clk-rockchip-rst-rk3588-Add-BIU-reset.patch has style problems, please review.

I see the above warning but that looks like a false positive to me.

> Best regards,
> Krzysztof
> _______________________________________________
> Kernel mailing list -- kernel at
> To unsubscribe send an email to kernel-leave at
> This list is managed by

More information about the Linux-rockchip mailing list