[PATCH 35/38] dt-bindings: arm: rockchip: Add rk3562 evb2 board

Diederik de Haas didi.debian at cknow.org
Fri Dec 20 07:30:24 PST 2024


Hi,

On Fri Dec 20, 2024 at 4:12 PM CET, Diederik de Haas wrote:
> The To/Cc list seems a bit short?

I now noticed that comment applies to quite a bit of the patches.
For dt-bindings patches I would at least include these:
- Rob Herring <robh at kernel.org>
- Krzysztof Kozlowski <krzk+dt at kernel.org>
- Conor Dooley <conor+dt at kernel.org>
- devicetree at vger.kernel.org
- linux-arm-kernel at lists.infradead.org

Next to the ones you did include.
``scripts/get_maintainers.pl <file>`` is a great help for this.

Alternatively and IIUC, b4 should take care of that for you.

Cheers,
  Diederik

> On Fri Dec 20, 2024 at 12:05 PM CET, Kever Yang wrote:
> > Add device tree documentation for rk3562-evb2-v10.
> >
> > Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> > ---
> >
> >  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index b2681a45867b..e300a817226a 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -1011,6 +1011,11 @@ properties:
> >            - const: rockchip,rk3566-box-demo
> >            - const: rockchip,rk3566
> >  
> > +      - description: Rockchip RK3562 Evaluation board 2
> > +        items:
> > +          - const: rockchip,rk3562-evb2-v10
> > +          - const: rockchip,rk3562
>
> I would expect RK3562 to come *before* RK3566.
> In your other/smaller patch set you corrected the sorting of Rockchip
> items; lets continue that 'tradition' ;-)
>
> Cheers,
>   Diederik
>
> > +
> >        - description: Rockchip RK3568 Evaluation board
> >          items:
> >            - const: rockchip,rk3568-evb1-v10

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20241220/d1e4814c/attachment.sig>


More information about the Linux-rockchip mailing list