[PATCH v5 10/12] arm64: dts: rockchip: Fix pmic dcdc-reg10 label for Radxa ROCK 5C
FUKAUMI Naoki
naoki at radxa.com
Mon Dec 16 16:47:45 PST 2024
On 12/16/24 22:40, Krzysztof Kozlowski wrote:
> On 16/12/2024 12:30, FUKAUMI Naoki wrote:
>> Fix pmic dcdc-reg10 label to match with schematic[1]. No functional
>> change.
>>
>> [1] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf
>>
>> Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
>
> All your commits have the same flaw. You claim there is no functional
> change, yet there is a real bug to fix.
>
> All such trivial cleanups are not fixes and should be squashed together.
I see, I'll do "squashed together" for trivial/cosmetic/no functional
changes without "Fixes" tag.
Thanks for pointing.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
> Best regards,
> Krzysztof
>
More information about the Linux-rockchip
mailing list