[PATCH v4 03/12] arm64: dts: rockchip: fix property for pwm-fan for Radxa ROCK 5C

[FUKAUMI Naoki]

Hi,

Thanks for your review!

On 12/10/24 01:32, Dragan Simic wrote:
> Hello Fukaumi,
> 
> On 2024-12-09 13:51, FUKAUMI Naoki wrote:
>> fix pwm period to match with vendor kernel[1].
> 
> Instead of simply referring to the downstream vendor kernel, in this
> specific case the reasons for adjusting the fan PWM parameters should
> be explained by referring to the actual fan setup you're using, the
> observed fan RPM behavior, etc.

original commit message is:

| arm64: dts: rockchip: modify fan pwm period to 60us
| Reduce pwm frequency to 16.6 KHz for a larger adjustable range of 
AO3416 mosfet.

I have no knowledge about this kind of things. Is quoting this message 
enough?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>> [1] https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/ 
>> arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
>>
>> Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
>> ---
>> Changes in v4:
>> - none
>> Changes in v3:
>> - none
>> Changes in v2:
>> - reword commit message
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
>> b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
>> index 630f026d856c..85589d1a6d3b 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
>> @@ -73,7 +73,7 @@ pwm-fan {
>>          #cooling-cells = <2>;
>>          cooling-levels = <0 64 128 192 255>;
>>          fan-supply = <&vcc_5v0>;
>> -        pwms = <&pwm3 0 10000 0>;
>> +        pwms = <&pwm3 0 60000 0>;
>>      };
>>
>>      pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
>