[PATCH 2/2] arm64: dts: rockchip: fix cooling-levels in pwm-fan for Radxa ROCK 5A/5C

FUKAUMI Naoki naoki at radxa.com
Mon Dec 9 04:04:49 PST 2024


Hi,

thank you for your review!

On 12/4/24 14:33, Dragan Simic wrote:
> Hello Fukaumi,
> 
> On 2024-12-04 05:54, FUKAUMI Naoki wrote:
>> fan behavior is better than current configuration.
> 
> Could you, please, describe better what makes this configuration
> better, which fan make and model are you using, etc.?

I have three Heatshink 2513[1] and I noticed they behave very 
differently... it's difficult to say which cooling-levels is better or 
worse with these heatsink.

I'll drop this patch.

Best regards,

[1] https://radxa.com/products/accessories/heatsink-2513

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
>> ---
>> this patch depends on [1] which depends on [2].
>>
>> [1] https://patchwork.kernel.org/project/linux-rockchip/ 
>> cover/20241128121929.62646-1-naoki at radxa.com/
>> [2] https://patchwork.kernel.org/project/linux-rockchip/ 
>> patch/20241119095113.78151-1-naoki at radxa.com/
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3588s-rock-5.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5.dtsi
>> index a1cac40d439e..472b41f0d47f 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5.dtsi
>> @@ -36,7 +36,7 @@ analog-sound {
>>      fan: fan {
>>          compatible = "pwm-fan";
>>          #cooling-cells = <2>;
>> -        cooling-levels = <0 64 128 192 255>;
>> +        cooling-levels = <0 120 150 180 210 240 255>;
>>          fan-supply = <&vcc_5v0>;
>>          pwms = <&pwm3 0 60000 0>;
>>      };
> 




More information about the Linux-rockchip mailing list