[PATCH 1/2] arm64: dts: rockchip: use Type-C port as USB HOST port for Radxa ROCK 5B

[FUKAUMI Naoki]

Hi Heiko and Sebastian,

thank you for your comments!

On 12/4/24 02:11, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Dec 03, 2024 at 05:18:39PM +0100, Heiko Stübner wrote:
>> Am Samstag, 30. November 2024, 02:40:42 CET schrieb FUKAUMI Naoki:
>>> Type-C port is dual-role USB 3.0 port. add usb_host0_xhci and phy
>>> nodes to use it as HOST port.
>>
>> This needs a bit more explanation on _why_ you're statically
>> setting this to host-mode.
> 
> The USB-C port can be used in peripheral mode, so this is just
> wrong. Also it should be added together with the USB PD controller
> for proper muxing and role switch support. The reason I have not yet
> send the patch is that this needed a fix in U-Boot first.
> 
> Most users are powering their Rock 5Bs via the USB-C port and a
> bad description results in unexpected hardware resets at boot
> time.
> 
> I mostly waited for the rc1 tag to happen now that U-Boot support
> has landed. Also I expect that even with all those precautions
> some people will start seeing issues. Unfortunately there are
> many non-compliant USB-PD power sources :(

I see. I'll wait proper implementation.
please ignore my patch.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> -- Sebastian
> 
>>
>> Heiko
>>
>>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
>>> ---
>>>   arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 17 +++++++++++++++++
>>>   1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> index 0ec4992b43cd..c5776e3b4aab 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> @@ -840,6 +840,14 @@ &tsadc {
>>>   	status = "okay";
>>>   };
>>>   
>>> +&u2phy0 {
>>> +	status = "okay";
>>> +};
>>> +
>>> +&u2phy0_otg {
>>> +	status = "okay";
>>> +};
>>> +
>>>   &u2phy1 {
>>>   	status = "okay";
>>>   };
>>> @@ -883,6 +891,11 @@ &usb_host0_ehci {
>>>   	status = "okay";
>>>   };
>>>   
>>> +&usb_host0_xhci {
>>> +	dr_mode = "host";
>>> +	status = "okay";
>>> +};
>>> +
>>>   &usb_host1_ehci {
>>>   	status = "okay";
>>>   };
>>> @@ -900,6 +913,10 @@ &usb_host2_xhci {
>>>   	status = "okay";
>>>   };
>>>   
>>> +&usbdp_phy0 {
>>> +	status = "okay";
>>> +};
>>> +
>>>   &usbdp_phy1 {
>>>   	status = "okay";
>>>   };
>>>
>>
>>
>>
>>