[PATCH 2/2] arm64: dts: rockchip: fix USB 3.0 bottom port for Radxa ROCK 5B

[Sebastian Reichel]

Hi,

On Tue, Dec 03, 2024 at 05:19:55PM +0100, Heiko Stübner wrote:
> Am Samstag, 30. November 2024, 02:40:43 CET schrieb FUKAUMI Naoki:
> > add rockchip,dp-lane-mux to usbdp_phy1 to make it work properly.
> 
> Make it work properly is not an ideal commit description.
> 
> I guess the lane assignment for the dp port should be discoverable
> in the device schematics, so the commit description should explain
> as much.

Rock 5B does not have SSRX2P/SSRX2N and SSTX2P/SSTX2N connected to
anything, so this description is just wrong. The other lanes are
connected to a USB-A port and thus no USB-C controller is involved,
which takes care of any muxing. Not specifying any
rockchip,dp-lane-mux configuration sets mode to UDPHY_MODE_USB,
which is correct.

Naoki, if you see any problems, it is most likely a bug in the USBDP
PHY or DWC3 driver.

Greetings,

-- Sebastian

> 
> > tested with ELECOM U3HC-A424P10BK[1]:
> > 
> > $ lsusb -t
> > /:  Bus 001.Port 001: Dev 001, Class=root_hub, Driver=ehci-platform/1p, 480M
> >     |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 480M
> >         |__ Port 003: Dev 003, If 0, Class=Wireless, Driver=btusb, 12M
> >         |__ Port 003: Dev 003, If 1, Class=Wireless, Driver=btusb, 12M
> > /:  Bus 002.Port 001: Dev 001, Class=root_hub, Driver=ohci-platform/1p, 12M
> > /:  Bus 003.Port 001: Dev 001, Class=root_hub, Driver=ehci-platform/1p, 480M
> > /:  Bus 004.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 480M
> > /:  Bus 005.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> >     |__ Port 001: Dev 002, If 0, Class=Mass Storage, Driver=usb-storage, 5000M
> > /:  Bus 006.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 480M
> >     |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/5p, 480M
> >         |__ Port 005: Dev 003, If 0, Class=Billboard, Driver=[none], 480M
> > /:  Bus 007.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> >     |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 5000M
> >         |__ Port 004: Dev 003, If 0, Class=Mass Storage, Driver=usb-storage, 5000M
> > /:  Bus 008.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 480M
> > /:  Bus 009.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> >     |__ Port 001: Dev 002, If 0, Class=Mass Storage, Driver=usb-storage, 5000M
> > 
> > [1] https://www.elecom.co.jp/products/U3HC-A424P10BK.html
> > 
> > Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > index c5776e3b4aab..43fc1f24dfc9 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > @@ -918,6 +918,7 @@ &usbdp_phy0 {
> >  };
> >  
> >  &usbdp_phy1 {
> > +	rockchip,dp-lane-mux = <2 3>;
> >  	status = "okay";
> >  };
> >  
> > 
> 
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20241203/fc62a61b/attachment.sig>