[PATCH 5/6] arm64: dts: rockchip: fix pwm-fan node for Radxa ROCK 5B

Alexey Charkov alchark at gmail.com
Mon Dec 2 05:39:46 PST 2024


Hi Naoki,

On Mon, Dec 2, 2024 at 5:35 PM FUKAUMI Naoki <naoki at radxa.com> wrote:
>
> fix properties to match with vendor kernel.
>
> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 7c8359fe712a..6a02febaefb7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -64,10 +64,10 @@ led-0 {
>
>         fan: pwm-fan {
>                 compatible = "pwm-fan";
> -               cooling-levels = <0 120 150 180 210 240 255>;
> -               fan-supply = <&vcc5v0_sys>;
> -               pwms = <&pwm1 0 50000 0>;
>                 #cooling-cells = <2>;
> +               cooling-levels = <0 64 128 192 255>;

Could you please share your testing setup for this part? In my
experience using Radxa 4010 fan, it didn't spin up reliably below 120,
so the value of 64 looks not helpful here.

Best regards,
Alexey



More information about the Linux-rockchip mailing list