[PATCH 10/10] pmdomain: renesas: rcar-sysc: Use scoped device node handling to simplify error paths
Geert Uytterhoeven
geert at linux-m68k.org
Tue Aug 27 00:55:23 PDT 2024
Hi Krzysztof,
On Fri, Aug 23, 2024 at 2:51 PM Krzysztof Kozlowski
<krzysztof.kozlowski at linaro.org> wrote:
> Obtain the device node reference with scoped/cleanup.h to reduce error
> handling and make the code a bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Thanks for your patch!
> --- a/drivers/pmdomain/renesas/rcar-sysc.c
> +++ b/drivers/pmdomain/renesas/rcar-sysc.c
> @@ -348,12 +349,12 @@ static int __init rcar_sysc_pd_init(void)
> const struct rcar_sysc_info *info;
> const struct of_device_id *match;
> struct rcar_pm_domains *domains;
> - struct device_node *np;
> void __iomem *base;
> unsigned int i;
> int error;
>
> - np = of_find_matching_node_and_match(NULL, rcar_sysc_matches, &match);
> + struct device_node *np __free(device_node) =
> + of_find_matching_node_and_match(NULL, rcar_sysc_matches, &match);
Same comment as on [PATCH 9/10].
> if (!np)
> return -ENODEV;
>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
More information about the Linux-rockchip
mailing list