[PATCH v4 5/8] arm64: dts: rockchip: add IR-receiver to NanoPC-T6

[Jonas Karlman]

Hi Marcin,

On 2024-08-22 15:32, Marcin Juszkiewicz wrote:
> FriendlyELEC NanoPC-T6 has IR receiver connected to PWM3_IR_M0 line
> which ends as GPIO0_D4.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz at linaro.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi
> index 292022a56332..fcea11ff2af2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi
> @@ -25,6 +25,11 @@ chosen {
>  		stdout-path = "serial2:1500000n8";
>  	};
>  
> +	ir-receiver {
> +		compatible = "gpio-ir-receiver";
> +		gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_LOW>;

I would expect to see pinctrl here that configure pin for gpio func use.

> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
>  
> @@ -228,7 +233,7 @@ &gpio0 {
>  			  "HEADER_10", "HEADER_08", "HEADER_32", "",
>  			  /* GPIO0 D0-D7 */
>  			  "", "", "", "",
> -			  "", "", "", "";
> +			  "IR receiver [PWM3_IR_M0]", "", "", "";
>  };
>  
>  &gpio1 {
> @@ -530,6 +535,13 @@ &pwm1 {
>  	status = "okay";
>  };
>  
> +/* Connected to IR Receiver */
> +&pwm3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pwm3m0_pins>;
> +	status = "okay";
> +};

Is this really needed/correct? A pinctrl for gpio func in ir-receiver
node should be enough for the ir-receiver?

Regards,
Jonas

> +
>  &saradc {
>  	vref-supply = <&avcc_1v8_s0>;
>  	status = "okay";
>