[PATCH v2 2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better

Dragan Simic dsimic at manjaro.org
Wed Aug 21 01:55:38 PDT 2024


On 2024-08-21 10:41, Heiko Stübner wrote:
> Am Mittwoch, 21. August 2024, 09:37:54 CEST schrieb Dragan Simic:
>> Return the actual error code upon failure to allocate extcon device, 
>> instead
>> of hardcoding -ENOMEM.  Use dev_err_probe() to also log appropriate 
>> messages,
>> which is fine because the containing function is used in the probe 
>> path.
>> 
>> Helped-by: Heiko Stubner <heiko at sntech.de>
> 
> How did I help with this? :-D
> 
> Reviewed-by: Heiko Stuebner <heiko at sntech.de>

Thanks for your review.  Well, you suggested that dev_err_probe() is 
used. :)



More information about the Linux-rockchip mailing list