[PATCH v2] arm64: dts: rockchip: add rfkill node for M.2 E wifi on orangepi-5-plus
Dragan Simic
dsimic at manjaro.org
Wed Aug 7 10:24:27 PDT 2024
On 2024-08-07 19:00, Florian Klink wrote:
> This follows the same logic as 82d40b141a4c ("arm64: dts: rockchip: add
> rfkill node for M.2 Key E WiFi on rock-5b").
>
> On the orangepi-5-plus, there's also a GPIO pin connecting the WiFi
> enable signal inside the M.2 Key E slot.
>
> The exact GPIO PIN can be validated in the Armbian rk-5.10-rkr4 kernel
> rk3588-orangepi-5-plus.dtsi file [1], which contains a `wifi_disable`
> node referencing RK_PC4 on &gpio0.
>
> Signed-off-by: Florian Klink <flokli at flokli.de>
> Tested-by: Florian Klink <flokli at flokli.de>
I forgot to mention that providing a Tested-by tag is redundant when
there's already a Signed-off-by tag, because the latter already implies
the former.
> Link:
> https://github.com/armbian/linux-rockchip/blob/9fbe23c9da24f236c6009f42d3f02c1ffb84c169/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> [1]
> ---
> arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> index e74871491ef5..c3a6812cc93a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> @@ -105,6 +105,13 @@ led {
> };
> };
>
> + rfkill {
> + compatible = "rfkill-gpio";
> + label = "rfkill-pcie-wlan";
> + radio-type = "wlan";
> + shutdown-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_HIGH>;
> + };
> +
> sound {
> compatible = "simple-audio-card";
> pinctrl-names = "default";
More information about the Linux-rockchip
mailing list