[PATCH 01/12] dt-bindings: PCI: snps,dw-pcie-ep: Add vendor specific reg-name
Rob Herring
robh at kernel.org
Thu Apr 25 08:54:42 PDT 2024
On Thu, Apr 25, 2024 at 10:49:28AM -0500, Rob Herring wrote:
> On Wed, Apr 24, 2024 at 05:16:19PM +0200, Niklas Cassel wrote:
> > Considering that some drivers (e.g. pcie-dw-rockchip.c) already use the
> > reg-name "apb" for the device tree binding in Root Complex mode
> > (snps,dw-pcie.yaml), it doesn't make sense that those drivers should use a
> > different reg-name when running in Endpoint mode (snps,dw-pcie-ep.yaml).
> >
> > Therefore, since "apb" is already defined in snps,dw-pcie.yaml, add it
> > also for snps,dw-pcie-ep.yaml.
> >
> > Signed-off-by: Niklas Cassel <cassel at kernel.org>
> > ---
> > Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> > index bbdb01d22848..00dec01f1f73 100644
> > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> > @@ -100,7 +100,7 @@ properties:
> > for new bindings.
> > oneOf:
> > - description: See native 'elbi/app' CSR region for details.
> > - enum: [ link, appl ]
> > + enum: [ apb, link, appl ]
>
> This section is for existing bindings. IOW, don't use or add to them
> for new users. New users should "See native 'elbi/app' CSR region".
Err, I guess this is an existing user for the most part.
Reviewed-by: Rob Herring (Arm) <robh at kernel.org>
More information about the Linux-rockchip
mailing list