[PATCH v7 08/26] PM / devfreq: rk3399_dmc,dfi: generalize DDRTYPE defines
Sascha Hauer
s.hauer at pengutronix.de
Mon Oct 16 06:10:25 PDT 2023
Heiko,
On Sat, Oct 07, 2023 at 02:43:04AM +0900, Chanwoo Choi wrote:
> On 23. 7. 4. 18:32, Sascha Hauer wrote:
> > The DDRTYPE defines are named to be RK3399 specific, but they can be
> > used for other Rockchip SoCs as well, so replace the RK3399_PMUGRF_
> > prefix with ROCKCHIP_. They are defined in a SoC specific header
> > file, so when generalizing the prefix also move the new defines to
> > a SoC agnostic header file. While at it use GENMASK to define the
> > DDRTYPE bitfield and give it a name including the full register name.
> >
> > Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.com>
> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > ---
[...]
> > + ROCKCHIP_DDRTYPE_LPDDR2 = 5,
> > + ROCKCHIP_DDRTYPE_LPDDR3 = 6,
> > + ROCKCHIP_DDRTYPE_LPDDR4 = 7,
> > +};
> > +
> > +#endif /* __SOC_ROCKCHIP_GRF_H */
>
>
> Acked-by: Chanwoo Choi <cw00.choi at samsung.com>
>
> This patch must require Ack of rockchip Maintainer (Heiko Stuebner)
> because of include/soc/rockchip.
Could you provide your Acked-by: for this patch?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the Linux-rockchip
mailing list