[PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes

[Heiko Stübner]

Am Montag, 27. November 2023, 11:55:21 CET schrieb Dragan Simic:
> On 2023-11-27 11:50, Heiko Stübner wrote:
> > Am Montag, 27. November 2023, 11:43:05 CET schrieb Dragan Simic:
> >> On 2023-11-27 11:29, Heiko Stübner wrote:
> >> > Am Montag, 27. November 2023, 10:58:43 CET schrieb Tim Lunn:
> >> >> On 11/27/23 20:45, Heiko Stübner wrote:
> >> >>> It's different for mmc, where this naming scheme isn't normally used,
> >> >>> so we (mostly?) migrated to them being in the board-specific alias
> >> >>> section.
> >> >>
> >> >> What about the ethernet alias, the MAC is part of the SoC, should this
> >> >> stay as it is in patch 6 from this series, or move to board dtsi?
> >> >
> >> > I think judging from everything above (and the other modern boards
> >> > like all rk3588 ones) the ethernet0 alias should move to the board
> >> > dts(i).
> >> >
> >> > The gmac generally does not have this numbering scheme like i2c or
> >> > uarts.
> >> 
> >> Please note there's already an Ethernet alias defined in rk3399.dtsi,
> >> even despite not all RK3399-based devices using the GMAC, for example
> >> the Pinebook Pro.  Perhaps that's something to be fixed as well.
> > 
> > possibly :-)
> > 
> > I guess for starters we shouldn't introduce new instances for it.
> 
> Totally agreed.
> 
> > All the newer SoCs already have their ethernet alias in the board dts
> > (rk356x, rk3568) which came after we also moved the mmc aliases.
> 
> The base rk3399.dtsi file and the RK3399-based board/device dts(i) files 
> are fine when it comes to the mmc aliases.  I can move forward and clean 
> up the Ethernet alias as well, if you agree?

Yep, we moved mmc aliases a while ago.

So moving the ethernet sounds like the right way forward. So if you have
the time for it, then I'd be quite happy to take patches for that change.


Thanks
Heiko