[PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes

[Dragan Simic]

On 2023-11-27 11:29, Heiko Stübner wrote:
> Am Montag, 27. November 2023, 10:58:43 CET schrieb Tim Lunn:
>> On 11/27/23 20:45, Heiko Stübner wrote:
>>> It's different for mmc, where this naming scheme isn't normally used,
>>> so we (mostly?) migrated to them being in the board-specific alias 
>>> section.
>> 
>> What about the ethernet alias, the MAC is part of the SoC, should this
>> stay as it is in patch 6 from this series, or move to board dtsi?
> 
> I think judging from everything above (and the other modern boards
> like all rk3588 ones) the ethernet0 alias should move to the board 
> dts(i).
> 
> The gmac generally does not have this numbering scheme like i2c or 
> uarts.

Please note there's already an Ethernet alias defined in rk3399.dtsi, 
even despite not all RK3399-based devices using the GMAC, for example 
the Pinebook Pro.  Perhaps that's something to be fixed as well.