[PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support

Javier Martinez Canillas javierm at redhat.com
Mon Mar 27 09:15:55 PDT 2023

Heiko Stübner <heiko at sntech.de> writes:

Hello Heiko,

> Am Montag, 27. März 2023, 17:39:57 CEST schrieb Javier Martinez Canillas:
>> Ondřej Jirman <megi at xff.cz> writes:
>> Hell Ondřej,
>> > Hi Javier,
>> >
>> > I've tried the patch on top of linus/master and it works as expected. My
>> > DRM test app shows 16.669ms between frames. The display output is ok on
>> > developer batch pinephone pro, and is corrupted on production version.
>> > Display also doesn't come back after blanking. All as expected.
>> >
>> > Tested-by: Ondrej Jirman <megi at xff.cz>
>> >
>> Thanks for testing.
>> > A few more comments below.
>> >
>> I'm OK with these comments but I did a git diff with your orange-pi-6.3
>> branch just before posting and this was the latest that's in your tree.
>> So feel free to either post a v3 addressing the things you are pointing
>> out or lets land this and we can post any further cleanups on top IMO.
> I would really like to _not_ apply essentially broken code, so really
> would prefer the v3-approach.

It is broken though? This is what is in Ondrej downstream tree and I see
no issues on my Pinephone Pro. He mentioned some flicker when looking at
the signals with a scope and hooking a photoresistor.

But that's fair. I'll let Ondrej then post a v3 if he wants to address the
issues he pointed out, since is his patch after all.

Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

More information about the Linux-rockchip mailing list