[PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R5S
heiko at sntech.de
Wed Mar 8 08:31:36 PST 2023
Am Mittwoch, 8. März 2023, 17:09:20 CET schrieb Vasily Khoruzhick:
> On Wed, Mar 8, 2023 at 3:31 AM Krzysztof Kozlowski
> <krzysztof.kozlowski at linaro.org> wrote:
> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > index 35f74eda30ae..0813ad22dc76 100644
> > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > @@ -201,6 +201,11 @@ properties:
> > > - friendlyarm,nanopi-r4s-enterprise
> > > - const: rockchip,rk3399
> > >
> > > + - description: FriendlyElec NanoPi R5S board
> > > +
> > Does not look like ordered alphabetically. Are you sure this is correct
> > place for it?
> Hmm, strictly speaking, "FriendlyElec NanoPi R5S board" should go in
> between of "FriendlyElec NanoPi R2S" and "FriendlyElec NanoPi4 series
> boards" if we want it in alphabetical order, not after "FriendlyElec
> NanoPi4 series boards" like in this patch. But it doesn't look nice
> (because R5S will go before R4S).
> There is already similar ordering (alphabetical/chronological for
> model) for Radxa Rock Pi - "Radxa ROCK Pi S", "Radxa Rock2 Square",
> "Radxa ROCK3 Model A", "Radxa ROCK 5 Model A".
> However if you want me to sort it strictly alphabetically, I can send a v2.
TL;DR: I think the entry is "just right" where it currently is :-)
- FriendlyElec NanoPi R2S
-> would become "FriendlyElec NanoPi2 series boards", _if_ there
will ever be some others
- FriendlyElec NanoPi R4S is included in the
"FriendlyElec NanoPi4 series boards"
and similarly the "FriendlyElec NanoPi R5S board" would become
"FriendlyElec NanoPi5 boards"
once they release more variants.
[Though we could get rid of the "board" in the current entry]
And judging by the amound of devices Pine64 did on the rk3568-base,
I guess it's fairly likely that FriendlyArm will release more in the future
as well, so the current position seems fitting.
More information about the Linux-rockchip