[PATCH] arm64: dts: rockchip: Lower SD card speed on Pinebook Pro

Dan Johansen strit at manjaro.org
Sun Mar 5 02:45:06 PST 2023


Den 05.03.2023 kl. 11.43 skrev Krzysztof Kozlowski:
> On 05/03/2023 11:04, Dan Johansen wrote:
>> Den 05.03.2023 kl. 10.52 skrev Krzysztof Kozlowski:
>>> On 04/03/2023 18:28, Dan Johansen wrote:
>>>> MicroSD card slot in the Pinebook Pro is located on a separate
>>>> daughterboard that's connected to the mainboard using a rather
>>>> long flat cable.  The resulting signal degradation causes many
>>>> perfectly fine microSD cards not to work in the Pinebook Pro,
>>>> which is a common source of frustration among the owners.
>>>>
>>>> Changing the mode and lowering the speed reportedly fixes this
>>>> issue and makes many microSD cards work as expected.
>>>>
>>>> Co-authored-by: Dragan Simic <dragan.simic at gmail.com>
>>> That's not a valid tag. Run checkpatch.
>>>
>>> Missing SoB, which would be pointed out by checkpatch with correct tag.
>> Thank you. I ran checkpatch and it just said it was not valid, didn't
>> give alternatives.
>>
>> Would Co-developed-by acceptable instead?
> Yes, looks good. If checkpatch does not complain, use it.
Thank you. It says there are no obvious issues, so will re-submit with 
that changed.
>
> Best regards,
> Krzysztof
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>



More information about the Linux-rockchip mailing list