[PATCH] pinctrl: rockchip: fix mux route data for rk3568

Jonas Karlman jonas at kwiboo.se
Mon Jan 16 07:41:50 PST 2023


Hi Linus,

On 2023-01-16 13:39, Linus Walleij wrote:
> On Wed, Jan 11, 2023 at 9:42 AM Jonas Karlman <jonas at kwiboo.se> wrote:
>> On 2023-01-10 10:42, jay.xu at rock-chips.com wrote:
>>> Hi Jonas
>>>
>>> A patch from https://github.com/rockchip-linux/kernel/commit/55aa440fb85377a8b8c7e4bbc367463c235da804
>>> can you try it ?
>>
>> Good that this was fixed in vendor kernel long time ago.
>> Could have saved me some hours of troubleshooting if it would have been upstreamed to mainline :-)
> 
> Hm hm some technical debt to pay off here I see. It happens
> to us all.
> 
> Jonas is your patch identical or do you want to send a more
> inspired version with more of the fixes from the vendor tree?

My patch should be good to go, it seem to match the code in latest vendor 5.10 tree.

The vendor tree does contain one additional detection pin for GMAC1 IO mux M1,
GPIO4_B7 (gmac1m1-miim) in addition to the existing GPIO4_A7 (gmac1m1-rx-bus2).
However, I do not see any need for what seem to be a superfluous detection pin,
all in-tree device tree select both gmac1m1-rx-bus2 and gmac1m1-miim.

Best regards,
Jonas

> 
> I'm certainly not going to sit and wait for the patch to come
> from another source, so I would like to apply some version of
> this patch.
> 
> Yours,
> Linus Walleij




More information about the Linux-rockchip mailing list