[PATCH] pinctrl: rockchip: fix reading pull type on rk3568

Linus Walleij linus.walleij at linaro.org
Mon Jan 16 04:43:25 PST 2023


On Tue, Jan 10, 2023 at 6:29 PM Jonas Karlman <jonas at kwiboo.se> wrote:

> When reading pinconf-pins from debugfs it fails to get the configured pull
> type on RK3568, "unsupported pinctrl type" error messages is also reported.
>
> Fix this by adding support for RK3568 in rockchip_get_pull, including a
> reverse of the pull-up value swap applied in rockchip_set_pull so that
> pull-up is correctly reported in pinconf-pins.
> Also update the workaround comment to reflect affected pins, GPIO0_D3-D6.
>
> Fixes: c0dadc0e47a8 ("pinctrl: rockchip: add support for rk3568")
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>

Patch applied for fixes. Thanks for fixing this!

Yours,
Linus Walleij



More information about the Linux-rockchip mailing list