[PATCH] arm64: dts: rockchip: add rk3566 audio nodes

[Furkan Kardame]

On Tuesday 10 January 2023 17:10:26 (+03:00), Heiko Stübner wrote:

> Am Dienstag, 10. Januar 2023, 15:08:50 CET schrieb Chen-Yu Tsai:
> > On Tue, Jan 10, 2023 at 10:05 PM Heiko Stuebner <heiko at sntech.de> wrote:
> > >
> > > On Mon, 9 Jan 2023 23:32:33 +0300, Furkan Kardame wrote:
> > > > This patch adds simple audio card nodes
> > > > Enabled i2s0_8ch as it is needed for hdmi audio
> > > > Added i2s1_8ch as it is needed for 3.5mm audio jack
> > > >
> > > >
> > >
> > > Applied - with remarks below!
> > >
> > > [1/1] arm64: dts: rockchip: add rk3566 audio nodes
> > >       commit: 9ce61898b3075892b01792fd3a44507b7e459c6f
> > >
> > >
> > > The core i2s at fe410000 node should _not_ go into a board devicetree.
> > > Thankfully an identical node for the i2s controller was already
> > > added to the core rk356x dt, so I've just dropped the one from
> > > your patch.
> > 
> > Shouldn't hdmi_sound also be enabled? Otherwise i2s0_8ch is enabled
> > for nothing.
> 
> Furkan, care to send a patch for that?
> 
> 
> 
> 


Sorry missed hdmi_audio, will add it to the patch.
I remember why i2s at fe410000 was added to the device tree.
It uses limited pinctrl-0 than the ones in rk356x.dtsi

I will fix these 2 points and send v2 soon.