[PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Mon Dec 25 03:15:56 PST 2023


On 25/12/2023 11:51, John Clark wrote:
> On 12/25/23 5:43 AM, Krzysztof Kozlowski wrote:
>> On 25/12/2023 11:20, John Clark wrote:
>>> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on
>>> the rock-5b it reboots instead.  Using the 'system-power-controller' allows
>>> the rk806 to power down instead.
>>>
>>> Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this
>>> issue for the nanopc-t6.
>> That's not the syntax I asked for. Where is its subject? Syntax is:
>> commit foo ("subject"), respecting the length of SHA, as checked by
>> checkpatch.
>>
>> You still miss v2 and changelog. I also wrote about this. b4 does it for
>> you, but if you decide to use git manually, then you have to add it.
>>
>> Best regards,
>> Krzysztof
>>
> The documentation for  --in-reply-to=<identifier> clearly states that it 

No, it does not state that.

> will generate the v2 semantics for the subject, yet it did not.  I used 

Because it doesn't...

> the message-id from the first message since it was a two email patch to 

Which you should not. Each submission is its own thread, which is
already expressed:

https://elixir.bootlin.com/linux/v6.7-rc7/source/Documentation/process/submitting-patches.rst#L782

> begin with.  It is not clear to me why this did not happen.  I will see 
> if I can find a sandbox to practice my get-send-email skills in.


Best regards,
Krzysztof




More information about the Linux-rockchip mailing list