[PATCH v2 1/3] ARM: dts: rockchip: Add psci for rk3036
Alex Bee
knaerzche at gmail.com
Wed Dec 20 03:16:14 PST 2023
Hi Andy,
Am 18.12.23 um 11:55 schrieb Andy Yan:
> From: Andy Yan <andy.yan at rock-chips.com>
>
> The system will hang at bringup secondary CPUs
> without psci node.
>
> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
>
> ---
>
> (no changes since v1)
>
> arch/arm/boot/dts/rockchip/rk3036.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi b/arch/arm/boot/dts/rockchip/rk3036.dtsi
> index 78686fc72ce6..5344803442a1 100644
> --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi
> @@ -67,6 +67,11 @@ display-subsystem {
> ports = <&vop_out>;
> };
>
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
I don't think that's an good idea. You most likely need that because you
have downstream bootloader installed on this board. PSCI implementation
takes place in TEE-OS for Rockchips ARM SoCs. There is no support for
RK3036 in upstream op-tee OS. It's pretty much the same for RK3128 and
RK3288.
If you use upstream u-boot it should be good as-is.
Alex
> timer {
> compatible = "arm,armv7-timer";
> arm,cpu-registers-not-fw-configured;
More information about the Linux-rockchip
mailing list