[PATCH 1/2] TSD: arm64: dts: rockchip: use codec as clock master
Jakob Unterwurzacher
jakobunt at gmail.com
Wed Aug 23 05:19:59 PDT 2023
From: Ermin Sunj <ermin.sunj at theobroma-systems.com>
If the codec is not the clock master, the MCLK needs to be
synchronous to both I2S_SCL ans I2S_LRCLK. We do not have that
on Haikou, causing distorted audio.
Before:
Running audioloopback.py script on Ringneck, 1kHz
output sine wave is not stable and shows distortion.
After:
10h stress tests audioloopback.py failed only one time.
That is 0.00014% failure rate.
Signed-off-by: Ermin Sunj <ermin.sunj at theobroma-systems.com>
---
arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
index 3a447d03e2a8..dafeef0c2dab 100644
--- a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
@@ -68,8 +68,10 @@ i2s0-sound {
simple-audio-card,format = "i2s";
simple-audio-card,name = "Haikou,I2S-codec";
simple-audio-card,mclk-fs = <512>;
+ simple-audio-card,frame-master = <&sgtl5000_codec>;
+ simple-audio-card,bitclock-master = <&sgtl5000_codec>;
- simple-audio-card,codec {
+ sgtl5000_codec: simple-audio-card,codec {
clocks = <&sgtl5000_clk>;
sound-dai = <&sgtl5000>;
};
--
2.39.2
More information about the Linux-rockchip
mailing list