[PATCH -next 1/2] media: camif-core: Do not check for 0 return after calling platform_get_irq()

Andrzej Pietrasiewicz andrzej.p at collabora.com
Wed Aug 2 23:39:35 PDT 2023


W dniu 3.08.2023 o 04:46, Ruan Jinjie pisze:
> It is not possible for platform_get_irq() to return 0. Use the
> return value from platform_get_irq().
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p at collabora.com>

> ---
>   drivers/media/platform/samsung/s3c-camif/camif-core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/samsung/s3c-camif/camif-core.c b/drivers/media/platform/samsung/s3c-camif/camif-core.c
> index afe1fcc37354..e4529f666e20 100644
> --- a/drivers/media/platform/samsung/s3c-camif/camif-core.c
> +++ b/drivers/media/platform/samsung/s3c-camif/camif-core.c
> @@ -381,8 +381,8 @@ static int camif_request_irqs(struct platform_device *pdev,
>   		init_waitqueue_head(&vp->irq_queue);
>   
>   		irq = platform_get_irq(pdev, i);
> -		if (irq <= 0)
> -			return -ENXIO;
> +		if (irq < 0)
> +			return irq;
>   
>   		ret = devm_request_irq(&pdev->dev, irq, s3c_camif_irq_handler,
>   				       0, dev_name(&pdev->dev), vp);




More information about the Linux-rockchip mailing list