[PATCH] spi: spi-rockchip: Fix missing unwind goto in rockchip_sfc_probe()

Li Lanzhe u202212060 at hust.edu.cn
Wed Apr 19 04:50:29 PDT 2023

If devm_request_irq() fails, then we are directly return 'ret' without 
clk_disable_unprepare(sfc->clk) and clk_disable_unprepare(sfc->hclk).

Fix this by changing direct return to a goto 'err_irq'.

Fixes: 0b89fc0a367e ("spi: rockchip-sfc: add rockchip serial flash controller")
Signed-off-by: Li Lanzhe <u202212060 at hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91 at hust.edu.cn>
The issue is found by static analysis and remains untested.
 drivers/spi/spi-rockchip-sfc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
index bd87d3c92dd3..69347b6bf60c 100644
--- a/drivers/spi/spi-rockchip-sfc.c
+++ b/drivers/spi/spi-rockchip-sfc.c
@@ -632,7 +632,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(dev, "Failed to request irq\n");
-		return ret;
+		goto err_irq;
 	ret = rockchip_sfc_init(sfc);

More information about the Linux-rockchip mailing list