[PATCH] mtd: nand: Convert to platform remove callback returning void

Tudor Ambarus tudor.ambarus at linaro.org
Sun Apr 9 22:37:11 PDT 2023

On 4/8/23 19:53, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> Acked-by: Nicolas Ferre <nicolas.ferre at microchip.com>
> Reviewed-by: Paul Cercueil <paul at crapouillou.net>
> Reviewed-by: Philippe Mathieu-Daudé <philmd at linaro.org>
> Acked-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> Acked-by: Roger Quadros <rogerq at kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
> Reviewed-by: Heiko Stuebner <heiko at sntech.de>
> Acked-by: Jernej Skrabec <jernej.skrabec at gmail.com>
> Acked-by: Thierry Reding <treding at nvidia.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

b4 seems didn't take my tag on 00/49, here it is again:
Acked-by: Tudor Ambarus <tudor.ambarus at linaro.org>

More information about the Linux-rockchip mailing list