[PATCH V10 3/4] power: supply: Add charger driver for Rockchip RK817

Peter Geis pgwipeout at gmail.com
Sun Oct 9 05:26:02 PDT 2022


On Sat, Oct 8, 2022 at 2:31 PM Philip C <subs at pscan.uk> wrote:
>
> I have a question about the RK817 driver.
>
> In Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml it
> says:-
> "extcon:
>      description:
>        Phandle to the extcon device providing the cable state for the
> otg phy."
>
> In the context of an RK356x/RK817 based device, is RK817 an "extcon
> device" that provides the cable state?

In the Rockchip inno usb2 phy implementation, the extcon is an
optional property that depends on your hardware design. If you have
wired up the vbus det and id lines correctly and have a simple usb
port, then you can leave this property out and the phy provides the
state to itself. If you have a complicated design, such as a usb-c
controller, or either the id or vbus det lines are broken, you'll need
to provide the extcon with a pointer to the device that is providing
this state.

The rk817 is not a valid extcon provider.

Very Respectfully,
Peter

>
> should I have statement like:-
> &usb2phy0 {
>    extcon = <&rk817>;
> };
> ?
>
> or maybe it should be extcon = <&otg_switch> ?
>
> In the BSP kernels it's done the other way round with the charger having
> an extcon declaring a phandle to the phy like this:-
>
> rk817: pmic at 20 {
>    charger {
>      extcon = <&usb2phy0>:
>    };
> };
>
> thanks, Philip C
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip



More information about the Linux-rockchip mailing list