[PATCH 11/20] gpio/rockchip: add of_node for gpiochip

[jay.xu at rock-chips.com]

Hi walleij

Thanks for revewing, i have got your reivews, and will update after heiko's review
to avoid too much patchset vision.

the gc->of_node is a fix for my patch serial, without this the gpiochip will fail to register.


BR
--------------
jay.xu at rock-chips.com
>On Tue, Oct 4, 2022 at 10:30 AM Andy Shevchenko
><andriy.shevchenko at linux.intel.com> wrote:
>> On Tue, Oct 04, 2022 at 09:14:38AM +0200, Linus Walleij wrote:
>> > On Tue, Sep 20, 2022 at 12:31 PM Jianqun Xu <jay.xu at rock-chips.com> wrote:
>> > > The Rockchip GPIO driver will probe before pinctrl and has no parent dt
>> > > node, lack of the of_node will cause the driver probe failure.
>> > >
>> > > Signed-off-by: Jianqun Xu <jay.xu at rock-chips.com>
>> >
>> > > +#ifdef CONFIG_OF_GPIO
>> > > +       gc->of_node = of_node_get(bank->dev->of_node);
>> > > +#endif
>> >
>> > Any introduction of of_node_get() needs to be balanced with a
>> > corresponding of_node_put().
>>
>> No, this code should not have been existed in the first place. We don't allow
>> anymore any of of_node usage in the GPIO drivers. There is an fwnode and parent
>> and logic to retrieve fwnode from parent in the GPIO library for the most of
>> the cases.
>
>Hm yeah given that the series want to introduce ACPI as well it makes
>a lot of sense.
>
>Yours,
>Linus Walleij