[PATCH v2 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

Sascha Hauer s.hauer at pengutronix.de
Wed May 11 01:21:07 PDT 2022


The VOP2 driver relies on reg-names properties, but these are not
documented. Add the missing documentation, make reg-names mandatory
and increase minItems to 2 as always both register spaces are needed.

Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---

Notes:
    Changes since v1:
    - Drop minItems
    - Add reg-names properties to example

 .../bindings/display/rockchip/rockchip-vop2.yaml          | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
index 655d9b327f7d3..fba45091d9092 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
@@ -22,7 +22,6 @@ properties:
       - rockchip,rk3568-vop
 
   reg:
-    minItems: 1
     items:
       - description:
           Must contain one entry corresponding to the base address and length
@@ -31,6 +30,11 @@ properties:
           Can optionally contain a second entry corresponding to
           the CRTC gamma LUT address.
 
+  reg-names:
+    items:
+      - const: vop
+      - const: gamma-lut
+
   interrupts:
     maxItems: 1
     description:
@@ -86,6 +90,7 @@ properties:
 required:
   - compatible
   - reg
+  - reg-names
   - interrupts
   - clocks
   - clock-names
@@ -104,6 +109,7 @@ examples:
             vop: vop at fe040000 {
                 compatible = "rockchip,rk3568-vop";
                 reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>;
+                reg-names = "vop", "gamma-lut";
                 interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
                 clocks = <&cru ACLK_VOP>,
                          <&cru HCLK_VOP>,
-- 
2.30.2




More information about the Linux-rockchip mailing list