[PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

[piotro.oniszczuk@google.com]

> Wiadomość napisana przez Sascha Hauer <s.hauer at pengutronix.de> w dniu 30.03.2022, o godz. 11:45:
> 
> On Wed, Mar 30, 2022 at 10:41:56AM +0200, piotro.oniszczuk at google.com wrote:
> 
> Let me rephrase this: The above sets a plane, but it doesn't set a mode
> on the crtc. When my system boots up then the output of modetest looks
> like this:
> 
> Encoders:
> id      crtc    type    possible crtcs  possible clones
> 68      0       TMDS    0x00000001      0x00000001
> Connectors:
> id      encoder status          name            size (mm)       modes  encoders
> 69      0       connected       HDMI-A-1        530x300         9      68
> CRTCs:
> id      fb      pos     size
> 67      0       (0,0)   (0x0)
>  #0  nan 0 0 0 0 0 0 0 0 0 flags: ; type: 
> 
> No mode is set on the CRTC and the encoder/connector/crtc are not bound
> to each other, consequently the screen is in standby. "modetest -P
> 43 at 67:1920x1080 at NV12" doesn't change this, still no mode set. Hence my
> question: How did you set a mode initially?

Ah ok. I see your point.
mode is set by app (player). 

Sequence was like this:
-boot board
-start app
-on UI select playback
-playback has green screen
-exit app
-run modetest -P 43 at 67:1920x1080 at NV12 (the same green screen like in playback)
-run modetest -P 49 at 67:1920x1080 at NV12 (works ok)
-run modetest -P 43 at 67:1920x1080 at NV12 (now works ok)

> 
>>> 
>> 
>> I'm not sure that above command only sets plane.
>> On other SoCs i’m testing it gives expected results: diagonal colored stripes.
>> There is single exception: rk356x with vop2 - where screen is green unless i „fix/enable” by playing with plane #69   
>> 
>>> I did with "modetest -s 69 at 67:1920x1080 -d" and with this it works as
>>> expected, I can't reproduce any green screen issue here.
>> 
>> I see you are using plane #69.
>> Why not #43?
> 
> I used "modetest -s 69 at 67:1920x1080 -d" to set a mode. The '69' is the
> connector id, not a plane.

ack.
typo from my side.

it was
modetest -P 49 at 67:1920x1080 at NV12


> 
>> Is plane #43 working ok for you?
> 
> Yes.

So it looks your testing method of #43 is not meaningful for verifying issue we are discussing here.

In my case:
12 SOC (except rk356x VOP2) gives me:
-boot board
-start app
-on UI select playback
-playback is ok
-exit app
-run modetest -P XX at YY:1920x1080 at NV12 (diagonal stripes)

(XX/YY are plane/connector elected by app: plane at conector with format matching provider format) 

rk356x with vop2 v9:
-boot board
-start app
-on UI select playback
-playback has green screen
-exit app
-run modetest -P 43 at 67:1920x1080 at NV12 (the same green screen like in playback)
-run modetest -P 49 at 67:1920x1080 at NV12 (works ok)
-run modetest -P 43 at 67:1920x1080 at NV12 (now works ok)