[PATCH v2 34/55] media: rkisp1: isp: Initialize some variables at declaration time

[paul.elder at ideasonboard.com]

Hi Laurent,

On Fri, Jul 01, 2022 at 02:06:52AM +0300, Laurent Pinchart wrote:
> Initialize the src_fmt and sink_fmt variable when declaring them in
> rkisp1_config_isp().
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Dafna Hirschfeld <dafna at fastmail.com>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
> Changes since v1:
> 
> - Fix typo in commit message
> ---
>  drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> index 938541ce52ce..53f0516594ef 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> @@ -142,12 +142,11 @@ static int rkisp1_config_isp(struct rkisp1_isp *isp,
>  {
>  	struct rkisp1_device *rkisp1 = isp->rkisp1;
>  	u32 isp_ctrl = 0, irq_mask = 0, acq_mult = 0, acq_prop = 0;
> -	const struct rkisp1_mbus_info *src_fmt, *sink_fmt;
> +	const struct rkisp1_mbus_info *sink_fmt = isp->sink_fmt;
> +	const struct rkisp1_mbus_info *src_fmt = isp->src_fmt;
>  	struct v4l2_mbus_framefmt *sink_frm;
>  	struct v4l2_rect *sink_crop;
>  
> -	sink_fmt = isp->sink_fmt;
> -	src_fmt = isp->src_fmt;
>  	sink_frm = rkisp1_isp_get_pad_fmt(isp, NULL,
>  					  RKISP1_ISP_PAD_SINK_VIDEO,
>  					  V4L2_SUBDEV_FORMAT_ACTIVE);