[PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

ty zonyitoo at gmail.com
Wed Dec 21 04:12:17 PST 2022


Hi, Kozlowski and Stübner,

Thank you very much for pointing me in the right direction.

> So how did you solve the comment "Does not look like properly ordered.
> Don't add stuff at the end of files/lists."? What did you change to
> solve it?

> for context sorting order in that file is alphabetical by description

I finally got it. It should be put right after the "Elgin RV1108 R1".

> You do not wrap at 75, but at some other place. Just put it to editor
> and check where is wrapping (count characters).

The original message was:

>  from: DHDAXCW <lasstp5011 at gmail.com>
>
> LubanCat 1 is a Rockchip RK3566 SBC based
> is developed by EmbedFire Electronics Co., Ltd.
> Mini Linux Card Type Cheap Computer Development Board
>
> Signed-off-by: Yuteng Zhong <zonyitoo at gmail.com>
> Signed-off-by: DHDAXCW <lasstp5011 at gmail.com>

The longest line is "Mini Linux Card Type Cheap Computer Development
Board", which has 53 characters. Or ... I should use the whole line as
much as possible? Then I see why I was doing wrong. It will be fixed
in the PATCH v5.



More information about the Linux-rockchip mailing list