[PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1

[ty]

Dear Kozlowski,

Before making a new PATCH v5 with the whole .dts file, here is a small
patch base on the current v4.

This node name was missed in this PATCH.

---

@@ -74,7 +74,7 @@

     vin-supply = <&usb_5v>;

   };



-  vcc3v3_sys: vcc3v3-sys {

+  vcc3v3_sys: vcc3v3-sys-regulator {

     compatible = "regulator-fixed";

     regulator-name = "vcc3v3_sys";

     regulator-always-on;



Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> 于2022年12月21日周三 16:15写道：
>
> On 21/12/2022 06:46, Yuteng Zhong wrote:
> > from: DHDAXCW <lasstp5011 at gmail.com>
> >
> > LubanCat 1 is a Rockchip RK3566 SBC based
> > is developed by EmbedFire Electronics Co., Ltd.
> > Mini Linux Card Type Cheap Computer Development Board
> >
> > It has the following characteristics:
> > - MicroSD card slot, onboard eMMC flash memory
> > - 1GbE Realtek RTL8211F Ethernet Transceiver
> > - 1 USB Type-C port (power and USB2.0 OTG)
> > - 1 USB 3.0 Host port
> > - 3 USB 2.0 Host ports
> > - 1 HDMI
> > - 1 infrared receiver
> > - 1 MIPI DSI
> > - 1 MIPI CSI
> > - 1 x 4-section headphone jack
> > - Mini PCIe socket (USB or PCIe)
> > - 1 SIM Card slot
> > - 1 SYS LED and 1 PWR LED
> > - 40-pin GPIO expansion header
> >
> > Signed-off-by: Yuteng Zhong <zonyitoo at gmail.com>
> > Signed-off-by: DHDAXCW <lasstp5011 at gmail.com>
> > ---
> >
> > Changed in V2:
> >   - Remove RNG node
> > Changed in V3:
> >   - Sent E-mail with a wrong attachment
> > Changed in V4:
> >   - Modify all node names
> >
> > ---
> >  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
> >  .../boot/dts/rockchip/rk3566-lubancat-1.dts   | 598 ++++++++++++++++++
> >  2 files changed, 599 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 0a76a2ebb5f6..e52bda04d45a 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> > new file mode 100644
> > index 000000000000..443fcfabbd16
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> > @@ -0,0 +1,598 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > +* Copyright (c) 2021 Rockchip Electronics Co., Ltd.
> > +*/
> > +
> > +/dts-v1/;
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/pinctrl/rockchip.h>
> > +#include <dt-bindings/soc/rockchip,vop2.h>
> > +#include "rk3566.dtsi"
> > +
> > +/ {
> > +     model = "EmbedFire LubanCat 1";
> > +     compatible = "embedfire,lubancat-1", "rockchip,rk3566";
> > +
> > +     aliases {
> > +             ethernet0 = &gmac1;
> > +             mmc0 = &sdmmc0;
> > +             mmc1 = &sdhci;
> > +     };
> > +
> > +     chosen: chosen {
> > +             stdout-path = "serial2:1500000n8";
> > +     };
> > +
> > +     gmac1_clkin: external-gmac1-clock {
> > +             compatible = "fixed-clock";
> > +             clock-frequency = <125000000>;
> > +             clock-output-names = "gmac1_clkin";
> > +             #clock-cells = <0>;
> > +     };
> > +
> > +     hdmi-con {
> > +             compatible = "hdmi-connector";
> > +             type = "a";
> > +
> > +             port {
> > +                     hdmi_con_in: endpoint {
> > +                             remote-endpoint = <&hdmi_out_con>;
> > +                     };
> > +             };
> > +     };
> > +
> > +     gpio-leds {
> > +             compatible = "gpio-leds";
> > +
> > +             sys_led: sys-led {
> > +                     label = "sys_led";
> > +                     linux,default-trigger = "heartbeat";
> > +                     default-state = "on";
> > +                     gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>;
> > +                     pinctrl-names = "default";
> > +                     pinctrl-0 = <&sys_led_pin>;
> > +             };
> > +     };
> > +
> > +     usb_5v: usb-5v-regulator {
> > +             compatible = "regulator-fixed";
> > +             regulator-name = "usb_5v";
> > +             regulator-always-on;
> > +             regulator-boot-on;
> > +             regulator-min-microvolt = <5000000>;
> > +             regulator-max-microvolt = <5000000>;
> > +     };
> > +
> > +     vcc5v0_sys: vcc5v0-sys-regulator {
> > +             compatible = "regulator-fixed";
> > +             regulator-name = "vcc5v0_sys";
> > +             regulator-always-on;
> > +             regulator-boot-on;
> > +             regulator-min-microvolt = <5000000>;
> > +             regulator-max-microvolt = <5000000>;
> > +             vin-supply = <&usb_5v>;
> > +     };
> > +
> > +     vcc3v3_sys: vcc3v3-sys {
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> > +             compatible = "regulator-fixed";
> > +             regulator-name = "vcc3v3_sys";
> > +             regulator-always-on;
> > +             regulator-boot-on;
> > +             regulator-min-microvolt = <3300000>;
> > +             regulator-max-microvolt = <3300000>;
> > +             vin-supply = <&vcc5v0_sys>;
> > +     };
> > +
> > +     vcc3v3_pcie: vcc3v3-pcie-regulator {
>
>
> Best regards,
> Krzysztof
>


-- 
Y. T. Zhong
Student of The University of Hong Kong, major in Computer Science.
E-mail: zonyitoo at gmail.com