[PATCH v2 3/3] arm64: dts: rockchip: add Anbernic RG353P and RG503

[Chris Morgan]

On Tue, Aug 23, 2022 at 03:28:52PM +0300, Krzysztof Kozlowski wrote:
> On 23/08/2022 15:16, Heiko Stübner wrote:
> > Am Samstag, 20. August 2022, 10:40:34 CEST schrieb Maya Matuszczyk:
> >> sob., 20 sie 2022 o 00:26 Chris Morgan <macroalpha82 at gmail.com> napisał(a):
> >>>
> >>> From: Chris Morgan <macromorgan at hotmail.com>
> > 
> > [...]
> > 
> >>> +&gpio_keys_control {
> >>> +       button-5 {
> >>> +               gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>;
> >>> +               label = "DPAD-LEFT";
> >>> +               linux,code = <BTN_DPAD_RIGHT>;
> >>> +       };
> >>> +
> >>> +       button-6 {
> >>> +               gpios = <&gpio3 RK_PA6 GPIO_ACTIVE_LOW>;
> >>> +               label = "DPAD-RIGHT";
> >>> +               linux,code = <BTN_DPAD_LEFT>;
> >>> +       };
> >>> +
> >>> +       button-9 {
> >>> +               gpios = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>;
> >>> +               label = "TR";
> >>> +               linux,code = <BTN_TR2>;
> >>> +       };
> >>> +
> >>> +       button-10 {
> >>> +               gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_LOW>;
> >>> +               label = "TR2";
> >>> +               linux,code = <BTN_TR>;
> >>> +       };
> >>> +
> >>> +       button-14 {
> >>> +               gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>;
> >>> +               label = "WEST";
> >>> +               linux,code = <BTN_WEST>;
> >>> +       };
> >>> +
> >>> +       button-15 {
> >> I don't think just having the buttons numbered sequentially
> >> is the best course of action, but this preserves the GPIO
> >> ordering while other options don't...
> >> I'm thinking about either having them named after
> >> their function, or named after what they're labeled
> >> on the PCB of the device.
> >> Can any of DT maintainers give their input on this?
> > 
> > Personally, I'd prefer going with what is on the PCB
> > or defined in the schematics.
> > 
> > This makes it way easier finding dt-elements either in
> > schematics or on the board itself.
> > 
> > This is true for all names ;-)
> > 
> > On the Odroid-Go for example buttons are really named
> > sw1, sw2, ... so the dt-name became button-sw1 etc.
> > 
> 
> Matching what's on the schematics/board makes sense.

I'll do my best (in regards to board name). Schematics won't be
possible as Anbernic hasn't released them.

> 
> Best regards,
> Krzysztof