[PATCH 2/4] gpio/rockchip: fix get_direction value handling

Linus Walleij linus.walleij at linaro.org
Fri Sep 17 16:30:21 PDT 2021

On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner <heiko at sntech.de> wrote:

> The function uses the newly introduced rockchip_gpio_readl_bit()
> which directly returns the actual value of the requeste bit.
> So using the existing bit-wise check for the bit inside the value
> will always return 0.
> Fix this by dropping the bit manipulation on the result.
> Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>

Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Linus Walleij

More information about the Linux-rockchip mailing list