[PATCH v7 2/5] media: rkisp1: stats: remove a wrong cast to u8
Heiko Stuebner
heiko.stuebner at theobroma-systems.com
Thu Jan 21 04:31:25 EST 2021
Am Mittwoch, 20. Januar 2021, 17:44:43 CET schrieb Dafna Hirschfeld:
> hist_bins is an array of type __u32. Each entry represent
> a 20 bit fixed point value as documented inline.
> The cast to u8 when setting the values is wrong. Remove it.
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld at collabora.com>
Reviewed-by: Heiko Stuebner <heiko at sntech.de>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
> index 3ddab8fa8f2d..4cdb180fa64d 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
> @@ -235,8 +235,7 @@ static void rkisp1_stats_get_hst_meas(struct rkisp1_stats *stats,
> pbuf->meas_type |= RKISP1_CIF_ISP_STAT_HIST;
> for (i = 0; i < RKISP1_CIF_ISP_HIST_BIN_N_MAX; i++)
> pbuf->params.hist.hist_bins[i] =
> - (u8)rkisp1_read(rkisp1,
> - RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
> + rkisp1_read(rkisp1, RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
> }
>
> static void rkisp1_stats_get_bls_meas(struct rkisp1_stats *stats,
>
More information about the Linux-rockchip
mailing list