[PATCH v7 0/5] Fix the rkisp1 userspace API for later IP versions
Dafna Hirschfeld
dafna.hirschfeld at collabora.com
Wed Jan 20 11:44:41 EST 2021
Hi,
This is v7 of the rkisp1 fixes set sent by Heiko Stuebner. [0]
In addition to prepare the support to px30 (V12 in the uapi)
This version of the set adds more fixes to the code in params/stats
according to the changes in the uapi and also change the
hist_bins to be u32 instead of u16.
More details about the patchset can be found in v6's cover-letter [1]
[0] https://patchwork.kernel.org/project/linux-media/list/?series=416647
[1] https://patchwork.kernel.org/project/linux-media/cover/20210118110448.275389-1-heiko@sntech.de/
changes since v6:
- add a patch to change the hist_bins array type to __u32 and extend the
documentation of how the histogram measurements are taken
- remove a wrong u8 cast when filling the hist_bins array
- when reducing the number of elements in the weight grid array,
the code in rkisp1-params.c should be adjusted to iterate it 25 times
- some minor typo and checkpatch fixes.
changes since v5:
- move grid reduction for V10 to separate patch (Hans)
- fix commit message (histogram size 28 -> 25) in patch4 (Hans)
changes since v4:
- set GAMMA_OUT to the real 25 instead of the 28 with 3 spares (Dafna)
- start RKISP_Vxx enum with 10 for RKISP_V10 to make output
easier and also allow userspace to differentiate between old (= 0)
and newer driver variants (Dafna, Laurent)
changes since v3:
- add patch fixing the original histogram size comment
- make comments in uapi more verbose (Hans)
- fix wording in admin guide (Hans)
- document version <-> soc in uapi as well (easier for people) (Dafna)
changes since v2:
- actually zero the correct sizes for u16 values (hist-bins)
(kernel-test-robot)
changes since v1:
- drop duplicate isp_ver storage, hw_revision is enough (Dafna)
- document multiple maximum sizes in uapi (Hans)
- document usage of hw_revision field (Hans)
- zero fields transmitted to userspace before adding data (Hans)
- use _V10 field sizes when filling fields, as there is only v10 for now
changes since rfc:
- move rkisp1_version enum into uapo
- show version in media-api hw_revision
- introduce constants for versions and make max use the biggest
Dafna Hirschfeld (2):
media: rkisp1: uapi: change hist_bins array type from __u16 to __u32
media: rkisp1: stats: remove a wrong cast to u8
Heiko Stuebner (3):
media: rockchip: rkisp1: reduce number of histogram grid elements in
uapi
media: rockchip: rkisp1: carry ip version information
media: rockchip: rkisp1: extend uapi array sizes
Documentation/admin-guide/media/rkisp1.rst | 16 ++++
.../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++--
.../platform/rockchip/rkisp1/rkisp1-params.c | 5 +-
.../platform/rockchip/rkisp1/rkisp1-stats.c | 15 +++-
include/uapi/linux/rkisp1-config.h | 84 ++++++++++++++++---
5 files changed, 116 insertions(+), 25 deletions(-)
--
2.17.1
More information about the Linux-rockchip
mailing list