[PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in the drivers

Bartosz Golaszewski brgl at bgdev.pl
Fri Dec 3 00:40:55 PST 2021


On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove these assignment all at once.
>
> For the details one may look into the of_gpio_dev_init() implementation.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---

I have a bad feeling about this but I've gone through the drivers in
this patch and it seems like you don't update any of the drivers that
use multiple child OF nodes so I can't really point out any obvious
bug.

I have another change I'm working on that's related, let me send it shortly.

Bart



More information about the Linux-rockchip mailing list