[PATCH] arm64: dts: rockchip: Re-add interrupt-names for RK3399's vpu

Heiko Stuebner heiko at sntech.de
Sun Aug 22 13:25:36 PDT 2021


Hi,

Am Sonntag, 22. August 2021, 16:37:24 CEST schrieb Ezequiel Garcia:
> Hi Alex, Heiko,
> 
> On Sun, 22 Aug 2021 at 08:58, Alex Bee <knaerzche at gmail.com> wrote:
> >
> > Commit a728c10dd62a ("arm64: dts: rockchip: remove interrupt-names from iommu nodes")
> > intended to remove the interrupt-names property for mmu nodes, but it
> > also removed it for the vpu node in rk3399.dtsi. That makes the driver
> > fail probing currently.
> > Fix this by re-adding the property for this node.
> >
> > Fixes: a728c10dd62a ("arm64: dts: rockchip: remove interrupt-names from iommu nodes")
> 
> AFAICS a728c10dd62a removed lots of interrupt-names properties
> from devices other than IOMMU.
> 
> Maybe it's best to revert it?

where did you see more mistakes in it?

I.e. first of all, at least when grepping through my kernel history, I only see
  commit 53a05c8f6e8e ("arm64: dts: rockchip: remove interrupt-names from iommu nodes")
with a different hash and at least there I see a lot of iommu interrupt removals
and this one line removing the vpu irqs in error.

So from my glance at it, applying Alex' patch should solve the issue?

Heiko





More information about the Linux-rockchip mailing list