[PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers

Krzysztof Wilczyński kw at linux.com
Mon Nov 30 10:30:28 EST 2020

Hi Lorenzo!

On 20-11-30 11:08:58, Lorenzo Pieralisi wrote:
> > Refactor pci_ecam_map_bus() function to use newly added constants so
> > that limits to the bus, device function and offset (now limited to 4K as
> > per the specification) are in place to prevent the defective or
> > malicious caller from supplying incorrect configuration offset and thus
> > targeting the wrong device when accessing extended configuration space.
> > This refactor also allows for the ".bus_shit" initialisers to be dropped
>                                           ^^^^
> Nice typo, I'd fix it while applying it though if you don't mind ;-),
> no need to resend it.

Oh doh!  Apologies. :)

> Jokes aside, nice piece of work, thanks for that.
> > when the user is not using a custom value as a default value will be
> > used as per the PCI Express Specification.
> > 
> > Suggested-by: Bjorn Helgaas <bhelgaas at google.com>
> > Signed-off-by: Krzysztof Wilczyński <kw at linux.com>
> I think Bjorn's reviewed-by still stands so I will apply it.

Thank you!


More information about the Linux-rockchip mailing list