[PATCH 04/10] PCI: altera: Remove dev_err() when handing an error from platform_get_irq()

Tan, Ley Foon ley.foon.tan at intel.com
Mon Aug 3 02:19:02 EDT 2020

> -----Original Message-----
> From: Krzysztof Wilczyński <kw at linux.com>
> Sent: Sunday, August 2, 2020 10:26 PM
> To: Bjorn Helgaas <bhelgaas at google.com>
> Cc: Jingoo Han <jingoohan1 at gmail.com>; Kukjin Kim <kgene at kernel.org>;
> Krzysztof Kozlowski <krzk at kernel.org>; Richard Zhu
> <hongxing.zhu at nxp.com>; Lucas Stach <l.stach at pengutronix.de>; Shawn
> Guo <shawnguo at kernel.org>; Sascha Hauer <s.hauer at pengutronix.de>;
> Murali Karicheri <m-karicheri2 at ti.com>; Yue Wang
> <yue.wang at Amlogic.com>; Kevin Hilman <khilman at baylibre.com>; Thomas
> Petazzoni <thomas.petazzoni at bootlin.com>; Jesper Nilsson
> <jesper.nilsson at axis.com>; Xiaowei Song <songxiaowei at hisilicon.com>;
> Binghui Wang <wangbinghui at hisilicon.com>; Pratyush Anand
> <pratyush.anand at gmail.com>; Hou Zhiqiang <Zhiqiang.Hou at nxp.com>;
> Linus Walleij <linus.walleij at linaro.org>; Toan Le
> <toan at os.amperecomputing.com>; Tan, Ley Foon
> <ley.foon.tan at intel.com>; Shawn Lin <shawn.lin at rock-chips.com>; Heiko
> Stuebner <heiko at sntech.de>; linux-amlogic at lists.infradead.org; linux-arm-
> kernel at axis.com; linux-arm-kernel at lists.infradead.org; linux-
> omap at vger.kernel.org; linux-pci at vger.kernel.org; linux-
> rockchip at lists.infradead.org; linux-samsung-soc at vger.kernel.org; linux-
> tegra at vger.kernel.org; rfi at lists.rocketboards.org
> Subject: [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error
> from platform_get_irq()
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from either the platform_get_irq() or
> platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> This change is as per suggestion from Coccinelle:
>   drivers/pci/controller/pcie-altera.c:717:2-9: line 717 is redundant
>   because platform_get_irq() already prints an error
> Suggested-by: Bjorn Helgaas <bhelgaas at google.com>
> Signed-off-by: Krzysztof Wilczyński <kw at linux.com>
> ---

Reviewed-by: Ley Foon Tan <ley.foon.tan at intel.com>

More information about the Linux-rockchip mailing list