[PATCH 4/4] arm64: dts: Sapphire board: Fix Type-C port supply

Vicente Bergas vicencb at gmail.com
Mon Sep 10 06:39:45 PDT 2018


On Mon, Sep 10, 2018 at 2:23 PM, Heiko Stuebner <heiko at sntech.de> wrote:
> Am Samstag, 8. September 2018, 21:00:48 CEST schrieb Vicente Bergas:
>> The reference is the schematic, page 11:
>> https://dl.vamrs.com/products/sapphire_excavator/RK_SAPPHIRE_SOCBOARD_RK3399_LPDDR3D178P232SD8_V12_20161109HXS.pdf
>> (alternate link)
>> http://opensource.rock-chips.com/images/f/f0/RK_Sapphire_RK3399.rar
>>
>> Signed-off-by: Vicente Bergas <vicencb at gmail.com>
>> ---
>>  .../arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
>> index b1cb50595..1188c8717 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
>> @@ -151,6 +151,16 @@
>>               vin-supply = <&vcc_sys>;
>>       };
>>
>> +     vcc5v0_typec0: vcc5v0-typec0-regulator {
>> +             compatible = "regulator-fixed";
>> +             enable-active-high;
>> +             gpio = <&gpio2 RK_PA0 GPIO_ACTIVE_HIGH>;
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&vcc5v0_typec0_en>;
>> +             regulator-name = "vcc5v0_typec0";
>> +             vin-supply = <&vcc_sys>;
>> +     };
>> +
>>       vcc_sys: vcc-sys {
>>               compatible = "regulator-fixed";
>>               regulator-name = "vcc_sys";
>> @@ -503,6 +513,10 @@
>>                       rockchip,pins =
>>                               <4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
>>               };
>> +             vcc5v0_typec0_en: vcc5v0-typec0-en {
>> +                     rockchip,pins =
>> +                             <2 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
>> +             };
>>       };
>>  };
>>
>> @@ -564,7 +578,7 @@
>>       };
>>
>>       u2phy0_host: host-port {
>> -             phy-supply = <&vcc5v0_host>;
>> +             phy-supply = <&vcc5v0_typec0>;
>
> Hmm, I'm not sure if that is correct.
>
> Reading schematics and also the phy port assignments, you can see
> u2phy0_host being connected to "usb_host0_ehci: usb at fe380000".
>
> So I guess the vcc5v0_host should be the correct one for it?
> Did you mean to add the py-supply to u2phy0_otg instead? Which is one
> of the ports used by the dwc3?
>
>
> Heiko
>
Hi,
from the schematic these are the connections for the USB ports:

##### PHY0 #####
U1000S is the RK3399 PHY0 used for the USB3 Type-C connector.
The USB3 Type-C connector is the one labeled J8902.
>From there, the VBUS pin is connected to the VBUS_TYPEC net.
The VBUS_TYPEC supply is U8905, which has an enable input
  connected to the GPIO2_A0/CIF_D0 net.
The GPIO2_A0/CIF_D0 net is driven by the
  GPIO2_A0/VOP_D0/CIF_D0/I2C2_SDA_u pin of U1000L, which is
  the RK3399.
################

##### PHY1 #####
U1000T is the RK3399 PHY1 used for the USB3 Type-A connector.
The USB3 Type-A connector is the one labeled CON602.
>From there, the VBUS pin is connected to the VCC5V0_HOST2 net.
The VCC5V0_HOST2 supply is U1902, which has an enable input
  connected to the VCC5V0_HOST_EN net.
The VCC5V0_HOST_EN net is driven by the
  GPIO4_D1/DP_HOTPLUG_d pin of U1000K, which is the RK3399.
################

So, it is clear that GPIO2_A0 controls the VBUS of PHY0 and
  GPIO4_D1 controls the VBUS of PHY1.

At this point, i am not sure how to translate this information
from the schematic into the DTS. I don't know if it should be
applied to the "otg" or the "host" side as you are suggesting.
But it looks quite clear to me that VCC5V0_HOST(GPIO4_D1) is not
applicaple to the PHY0.

As stated in the email 0/4, this patch only powers-up the Type-C
port, but it is still non-working. So, either this patch is wrong
or more changes are needed like the fusb302.

The reference should be the one from the manufacturer:
https://github.com/rockchip-linux/kernel/blob/release-4.4/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
but it contains the same bugs.

So, any help will be appreciated.

Regards,
  Vicenç.



More information about the Linux-rockchip mailing list